petern48 commented on code in PR #20610:
URL: https://github.com/apache/datafusion/pull/20610#discussion_r2885148688
##########
datafusion/optimizer/src/simplify_expressions/regex.rs:
##########
@@ -15,10 +15,14 @@
// specific language governing permissions and limitations
// under the License.
-use datafusion_common::{DataFusionError, Result, ScalarValue};
+use datafusion_common::tree_node::Transformed;
+use datafusion_common::{DataFusionError, Result};
use datafusion_expr::{BinaryExpr, Expr, Like, Operator, lit};
+use datafusion_functions::expr_fn::contains;
Review Comment:
hmm, i hadn't checked that actually. sorry, I honestly just blindly followed
the idea from the issue. Though now that I take a quick skim at [the arrow
code](https://github.com/apache/arrow-rs/blob/5025e6825971c7618532515b572026c61f8589b8/arrow-string/src/like.rs#L186),
I actually don't quite think that's the case (they are separate kernels that
were placed in the same file). I'll investigate a little more to check that
there's not some logic somewhere else that effectively does this optimization
already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
