jonathanc-n commented on code in PR #20570:
URL: https://github.com/apache/datafusion/pull/20570#discussion_r2879485712
##########
datafusion/physical-plan/src/execution_plan.rs:
##########
@@ -477,7 +477,7 @@ pub trait ExecutionPlan: Debug + DisplayAs + Send + Sync {
/// If statistics are not available, should return
[`Statistics::new_unknown`]
/// (the default), not an error.
/// If `partition` is `None`, it returns statistics for the entire plan.
- fn partition_statistics(&self, partition: Option<usize>) ->
Result<Statistics> {
+ fn partition_statistics(&self, partition: Option<usize>) ->
Result<Arc<Statistics>> {
Review Comment:
Makes sense to me. If I have the time, I'll try to do the the follow pull
request, revert this API change and deprecate the original function in favour
of the new one with Arc<Statistics> passed into the arguments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
