jayzhan211 commented on code in PR #11487: URL: https://github.com/apache/datafusion/pull/11487#discussion_r1679242010
########## datafusion/sql/src/expr/identifier.rs: ########## @@ -135,16 +138,17 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> { let nested_name = nested_names[0].to_string(); let col = Expr::Column(Column::from((qualifier, field))); - if let Some(udf) = - self.context_provider.get_function_meta("get_field") Review Comment: We can use the result of `self.normalizer.normalize()` as the planner arguments, similar to the spirit of others function that we take the result of `sql_expr_to_logical_expr` as the planner arguments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org