erenavsarogullari commented on code in PR #20375:
URL: https://github.com/apache/datafusion/pull/20375#discussion_r2881800923
##########
datafusion/execution/src/disk_manager.rs:
##########
@@ -420,7 +420,8 @@ impl RefCountedTempFile {
let global_disk_usage =
self.disk_manager.used_disk_space.load(Ordering::Relaxed);
if global_disk_usage > self.disk_manager.max_temp_directory_size {
return resources_err!(
- "The used disk space during the spilling process has exceeded
the allowable limit of {}. Try increasing the `max_temp_directory_size` in the
disk manager configuration.",
+ "The used disk space during the spilling process has exceeded
the allowable limit of {}. \
+ Please try increasing the config:
`datafusion.runtime.max_temp_directory_size`.",
Review Comment:
> What you pointed out is absolutely right – existing ConfigEntry::new_…
calls just inline the string and there isn’t a “global constants” module that
every caller uses.
Let's leave it as a separate wider issue to be addressed later.
I think `global constants` covering all DF configs (specially Rust source
files (`*.rs`)) can be useful for the end-users as well because when they
extend/maintain DF fork, they can also use this new infra by avoiding config
name duplication and drift risk. In terms of these, does it make sense to
create a separate issue to support global constants covering all DF configs?
If so, i can create and work on this.
> It would be useful but it's not in the existing ConfigEntry struct and no
convention.
I think it would have to be a separate PR to update ConfigEntry with
additional version field and helpers.
Until then the only way to know when a key was added is to look at the
changelog/commit history.
Yes, currently, `ConfigEntry` `struct` does not have `version` property and
we introduce new releases frequently so to track when the config/feature is
added, can also be useful. Does it also make sense to create a separate issue
for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
