xanderbailey commented on code in PR #20672:
URL: https://github.com/apache/datafusion/pull/20672#discussion_r2884412856
##########
datafusion/physical-plan/src/spill/spill_pool.rs:
##########
@@ -1343,6 +1368,88 @@ mod tests {
Ok(())
}
+ /// Regression test for data loss when multiple writer clones are used.
+ ///
+ /// `SpillPoolWriter` is `Clone`, and in non-preserve-order repartitioning
+ /// mode all input partition tasks share clones of the same writer. Before
+ /// the fix, `Drop` unconditionally set `writer_dropped = true` even when
+ /// other clones were still alive. This caused the `SpillPoolReader` to
+ /// return EOF prematurely, silently losing every batch written by the
+ /// remaining writers.
Review Comment:
Yep, that makes sense to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
