xanderbailey commented on code in PR #20672:
URL: https://github.com/apache/datafusion/pull/20672#discussion_r2886047254
##########
datafusion/physical-plan/src/spill/spill_pool.rs:
##########
@@ -233,6 +249,15 @@ impl Drop for SpillPoolWriter {
fn drop(&mut self) {
let mut shared = self.shared.lock();
+ shared.active_writer_count -= 1;
Review Comment:
I like that idea, it seems more future proof, tried it here
[52a06a4](https://github.com/apache/datafusion/pull/20672/commits/52a06a40889fb20837bbc4ad9083a9b92ba2859f)
what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
