alamb commented on code in PR #1409:
URL:
https://github.com/apache/datafusion-python/pull/1409#discussion_r2886415731
##########
python/datafusion/dataframe.py:
##########
@@ -1389,9 +1390,12 @@ def fill_null(self, value: Any, subset: list[str] | None
= None) -> DataFrame:
DataFrame with null values replaced where type casting is possible
Examples:
- >>> df = df.fill_null(0) # Fill all nulls with 0 where possible
- >>> # Fill nulls in specific string columns
- >>> df = df.fill_null("missing", subset=["name", "category"])
+ >>> from datafusion import SessionContext, col
Review Comment:
Thanks @ntjohnson1
Did you verify from the CI run logs that these tests are now run? I took a
brief look and couldn't find anything that was new
https://github.com/apache/datafusion-python/actions/runs/22687531822/job/65776433980?pr=1409
🤔
##########
pyproject.toml:
##########
@@ -70,6 +70,9 @@ features = ["substrait"]
[tool.pytest.ini_options]
asyncio_mode = "auto"
asyncio_default_fixture_loop_scope = "function"
+addopts = "--doctest-modules"
Review Comment:
matches https://docs.pytest.org/en/stable/how-to/doctest.html 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
