ntjohnson1 commented on code in PR #1409:
URL: 
https://github.com/apache/datafusion-python/pull/1409#discussion_r2886473499


##########
python/datafusion/dataframe.py:
##########
@@ -1389,9 +1390,12 @@ def fill_null(self, value: Any, subset: list[str] | None 
= None) -> DataFrame:
             DataFrame with null values replaced where type casting is possible
 
         Examples:
-            >>> df = df.fill_null(0)  # Fill all nulls with 0 where possible
-            >>> # Fill nulls in specific string columns
-            >>> df = df.fill_null("missing", subset=["name", "category"])
+            >>> from datafusion import SessionContext, col

Review Comment:
   The doctests run as a part of pytest so if you click on `Run Tests` you can 
see the new doctest entries.
   
   There aren't that many examples in the code at the moment. 
   If you scroll all the way to the bottom you can now see source code showing 
up in addition to test code
   ```console
   python/datafusion/dataframe.py::datafusion.dataframe.DataFrame.fill_null 
PASSED [ 99%]
   python/datafusion/dataframe.py::datafusion.dataframe.DataFrame.into_view 
PASSED [ 99%]
   
python/datafusion/dataframe_formatter.py::datafusion.dataframe_formatter.configure_formatter
 PASSED [ 99%]
   
python/datafusion/dataframe_formatter.py::datafusion.dataframe_formatter.get_formatter
 PASSED [ 99%]
   
python/datafusion/dataframe_formatter.py::datafusion.dataframe_formatter.reset_formatter
 PASSED [ 99%]
   
python/datafusion/dataframe_formatter.py::datafusion.dataframe_formatter.set_formatter
 PASSED [100%]
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to