Jefffrey commented on code in PR #20366: URL: https://github.com/apache/datafusion/pull/20366#discussion_r2887202644
########## datafusion/functions-aggregate/src/approx_percentile_cont_with_weight.rs: ########## @@ -45,18 +45,18 @@ create_func!( /// Computes the approximate percentile continuous with weight of a set of numbers pub fn approx_percentile_cont_with_weight( - order_by: Sort, + expr: Expr, Review Comment: This is intended since these functions ignore null values, so specifying `nulls_first` or `nulls_last` has no effect currently -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
