Jefffrey commented on code in PR #20616:
URL: https://github.com/apache/datafusion/pull/20616#discussion_r2887340520
##########
datafusion/functions/src/string/common.rs:
##########
@@ -331,6 +332,22 @@ fn string_trim<T: OffsetSizeTrait, Tr: Trimmer>(args:
&[ArrayRef]) -> Result<Arr
}
}
+pub(crate) fn case_conversion_return_type(
Review Comment:
I believe we can remove this function entirely in favour of just
`Ok(arg_types[0].clone())` in the return type implementation; it does mean
omitting dictionary handling but it seems the actual invoke code for
lower/upper functions don't handle dictionaries anyway?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
