LiaCastaneda commented on code in PR #18921:
URL: https://github.com/apache/datafusion/pull/18921#discussion_r2895902831
##########
datafusion/substrait/src/logical_plan/producer/expr/mod.rs:
##########
@@ -152,6 +152,9 @@ pub fn to_substrait_rex(
not_impl_err!("Cannot convert {expr:?} to Substrait")
}
Expr::Unnest(expr) => not_impl_err!("Cannot convert {expr:?} to
Substrait"),
+ Expr::LambdaFunction(expr) => producer.handle_lambda_function(expr,
schema),
+ Expr::Lambda(expr) => not_impl_err!("Cannot convert {expr:?} to
Substrait"), // not yet implemented in substrait-rs
+ Expr::LambdaVariable(expr) => not_impl_err!("Cannot convert {expr:?}
to Substrait"), // not yet implemented in substrait-rs
Review Comment:
@benbellick added some in the substrait spec in
https://github.com/substrait-io/substrait/pull/889, but might not be released
yet. I wonder if the expressions can actually be mapped 1:1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
