gstvg commented on code in PR #18921: URL: https://github.com/apache/datafusion/pull/18921#discussion_r2902626011
########## datafusion/substrait/src/logical_plan/producer/substrait_producer.rs: ########## Review Comment: Yes, thanks https://github.com/apache/datafusion/pull/18921/commits/83dfbdd13e98be8a00f90becc26f5b9f277eebff I believe we are going to produce a regular `ScalarFunction` for `LambdaFunction` nodes, so I added the note where scalar functions are handled The unimplemented notes for `Lambda` and `LambdaParameterReference` are added when upgrading substrait-rs on #20750: https://github.com/apache/datafusion/pull/20750/changes#diff-a6f9b212a27eb5019705752e4a035c4fa8e8c55b60c95326660f38ae839e9ad2R59-R61 https://github.com/apache/datafusion/pull/20750/changes#diff-eb46b65774adea5cafd3039875348693a50015639ec21d0409a5e2acdbf74eaeR96-R98 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
