timsaucer commented on code in PR #20454:
URL: https://github.com/apache/datafusion/pull/20454#discussion_r2902054318
##########
datafusion/ffi/src/udf/mod.rs:
##########
@@ -181,28 +185,22 @@ unsafe extern "C" fn invoke_with_args_fn_wrapper(
})
.collect::<Result<Vec<FieldRef>>>();
let arg_fields = rresult_return!(arg_fields);
+ let config_options =
rresult_return!(ConfigOptions::try_from(config_options));
+ let config_options = Arc::new(config_options);
let args = ScalarFunctionArgs {
args,
arg_fields,
number_rows,
return_field,
- // TODO: pass config options:
https://github.com/apache/datafusion/issues/17035
- config_options: Arc::new(ConfigOptions::default()),
+ config_options,
};
- let result = rresult_return!(
+ rresult!(
udf.inner()
.invoke_with_args(args)
- .and_then(|r| r.to_array(number_rows))
- );
-
- let (result_array, result_schema) =
rresult_return!(to_ffi(&result.to_data()));
-
- RResult::ROk(WrappedArray {
- array: result_array,
- schema: WrappedSchema(result_schema),
- })
+ .and_then(FFI_ColumnarValue::try_from)
+ )
}
Review Comment:
This is the only change of much significance in the PR. Everything else is
plumbing or tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
