alamb commented on code in PR #20780:
URL: https://github.com/apache/datafusion/pull/20780#discussion_r2911479177
##########
datafusion/sql/tests/cases/plan_to_sql.rs:
##########
@@ -1984,7 +1984,7 @@ fn test_complex_order_by_with_grouping() -> Result<()> {
}, {
assert_snapshot!(
sql,
- @r#"SELECT j1.j1_id, j1.j1_string, lochierarchy FROM (SELECT
j1.j1_id, j1.j1_string, (grouping(j1.j1_id) + grouping(j1.j1_string)) AS
lochierarchy, grouping(j1.j1_string), grouping(j1.j1_id) FROM j1 GROUP BY
ROLLUP (j1.j1_id, j1.j1_string)) ORDER BY lochierarchy DESC NULLS FIRST, CASE
WHEN (("grouping(j1.j1_id)" + "grouping(j1.j1_string)") = 0) THEN j1.j1_id END
ASC NULLS LAST LIMIT 100"#
+ @"SELECT j1.j1_id, j1.j1_string, (grouping(j1.j1_id) +
grouping(j1.j1_string)) AS lochierarchy FROM j1 GROUP BY ROLLUP (j1.j1_id,
j1.j1_string) ORDER BY lochierarchy DESC NULLS FIRST, CASE WHEN (lochierarchy =
0) THEN j1.j1_id END ASC NULLS LAST LIMIT 100"
Review Comment:
that certainly looks nicer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
