buraksenn commented on code in PR #20780: URL: https://github.com/apache/datafusion/pull/20780#discussion_r2912391907
########## datafusion/sqllogictest/test_files/clickbench.slt: ########## @@ -205,24 +205,22 @@ query TT EXPLAIN SELECT "AdvEngineID", COUNT(*) FROM hits WHERE "AdvEngineID" <> 0 GROUP BY "AdvEngineID" ORDER BY COUNT(*) DESC; ---- logical_plan -01)Projection: hits.AdvEngineID, count(*) -02)--Sort: count(Int64(1)) AS count(*) AS count(*) DESC NULLS FIRST -03)----Projection: hits.AdvEngineID, count(Int64(1)) AS count(*), count(Int64(1)) -04)------Aggregate: groupBy=[[hits.AdvEngineID]], aggr=[[count(Int64(1))]] -05)--------SubqueryAlias: hits -06)----------Filter: hits_raw.AdvEngineID != Int16(0) -07)------------TableScan: hits_raw projection=[AdvEngineID], partial_filters=[hits_raw.AdvEngineID != Int16(0)] +01)Sort: count(*) AS count(*) DESC NULLS FIRST Review Comment: I think I understood what to do but there can be side effects that I cant see. I will open a PR tomorrow for your review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
