coderfender commented on code in PR #20555: URL: https://github.com/apache/datafusion/pull/20555#discussion_r2912829617
########## datafusion/sqllogictest/test_files/spark/conversion/cast_int_to_timestamp.slt: ########## @@ -0,0 +1,194 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at + +# http://www.apache.org/licenses/LICENSE-2.0 + +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# Test spark_cast from int8 to timestamp +query P +SELECT spark_cast(arrow_cast(0, 'Int8'), 'timestamp'); +---- +1970-01-01T00:00:00Z + +query P +SELECT spark_cast(arrow_cast(1, 'Int8'), 'timestamp'); +---- +1970-01-01T00:00:01Z + +query P +SELECT spark_cast(arrow_cast(-1, 'Int8'), 'timestamp'); +---- +1969-12-31T23:59:59Z + +# Test spark_cast from int16 to timestamp +query P +SELECT spark_cast(arrow_cast(0, 'Int16'), 'timestamp'); +---- +1970-01-01T00:00:00Z + +query P +SELECT spark_cast(arrow_cast(3600, 'Int16'), 'timestamp'); +---- +1970-01-01T01:00:00Z + +# Test spark_cast from int32 to timestamp +query P +SELECT spark_cast(arrow_cast(0, 'Int32'), 'timestamp'); +---- +1970-01-01T00:00:00Z + +query P +SELECT spark_cast(arrow_cast(1704067200, 'Int32'), 'timestamp'); +---- +2024-01-01T00:00:00Z + +# Test spark_cast from int64 to timestamp +query P +SELECT spark_cast(0::bigint, 'timestamp'); +---- +1970-01-01T00:00:00Z + +query P +SELECT spark_cast(1704067200::bigint, 'timestamp'); +---- +2024-01-01T00:00:00Z + +# Test NULL handling +query P +SELECT spark_cast(arrow_cast(NULL, 'Int8'), 'timestamp'); +---- +NULL + +query P +SELECT spark_cast(arrow_cast(NULL, 'Int16'), 'timestamp'); +---- +NULL + +query P +SELECT spark_cast(arrow_cast(NULL, 'Int32'), 'timestamp'); +---- +NULL + +query P +SELECT spark_cast(NULL::bigint, 'timestamp'); +---- +NULL + +# Test untyped NULL +query P +SELECT spark_cast(NULL, 'timestamp'); +---- +NULL + +# Test Int8 boundary values +query P +SELECT spark_cast(arrow_cast(127, 'Int8'), 'timestamp'); +---- +1970-01-01T00:02:07Z + +query P +SELECT spark_cast(arrow_cast(-128, 'Int8'), 'timestamp'); +---- +1969-12-31T23:57:52Z + +# Test Int16 boundary values +query P +SELECT spark_cast(arrow_cast(32767, 'Int16'), 'timestamp'); +---- +1970-01-01T09:06:07Z + +query P +SELECT spark_cast(arrow_cast(-32768, 'Int16'), 'timestamp'); +---- +1969-12-31T14:53:52Z + +# Test Int64 negative value +query P +SELECT spark_cast(-86400::bigint, 'timestamp'); +---- +1969-12-31T00:00:00Z + +# Test unsupported source type - should error +statement error +SELECT spark_cast('2024-01-01', 'timestamp'); + +# Test unsupported target type - should error +statement error +SELECT spark_cast(100, 'string'); + +# Test with different session timezones to verify simplify() picks up config + +# America/Los_Angeles (PST/PDT - has DST) +statement ok +SET datafusion.execution.time_zone = 'America/Los_Angeles'; + +# Epoch in PST (UTC-8) +query P +SELECT spark_cast(0::bigint, 'timestamp'); +---- +1969-12-31T16:00:00-08:00 + +# 2024-01-01 00:00:00 UTC in PST (winter, UTC-8) +query P +SELECT spark_cast(1704067200::bigint, 'timestamp'); +---- +2023-12-31T16:00:00-08:00 + +# America/Phoenix (MST - no DST, always UTC-7) +statement ok +SET datafusion.execution.time_zone = 'America/Phoenix'; + +# Epoch in Phoenix (UTC-7) +query P +SELECT spark_cast(0::bigint, 'timestamp'); +---- +1969-12-31T17:00:00-07:00 + +# 2024-01-01 00:00:00 UTC in Phoenix (still UTC-7, no DST) +query P +SELECT spark_cast(1704067200::bigint, 'timestamp'); +---- +2023-12-31T17:00:00-07:00 + +# Test with different timezones - LA (has DST) +statement ok +SET datafusion.execution.time_zone = 'America/Los_Angeles'; + +query P +SELECT spark_cast(1710054000::bigint, 'timestamp'); +---- +2024-03-09T23:00:00-08:00 Review Comment: True but the DST started with March 10 2024 . We are comparing DST effect on various timezones here (including Phoenix which doesnt observe DST) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
