comphead commented on code in PR #3289:
URL: https://github.com/apache/datafusion-comet/pull/3289#discussion_r2914972029
##########
native/core/src/execution/shuffle/spark_unsafe/row.rs:
##########
@@ -501,7 +533,667 @@ pub(super) fn append_field(
Ok(())
}
+/// Appends nested struct fields to the struct builder using field-major order.
+/// This is a helper function for processing nested struct fields recursively.
+///
+/// Unlike `append_struct_fields_field_major`, this function takes slices of
row addresses,
+/// sizes, and null flags directly, without needing to navigate from a parent
row.
+#[allow(clippy::redundant_closure_call)]
+fn append_nested_struct_fields_field_major(
Review Comment:
IMO the name is slightly confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
