2010YOUY01 commented on PR #20832: URL: https://github.com/apache/datafusion/pull/20832#issuecomment-4038074313
> > It should already be enabled for `[profile.ci]` though, right? I don't mind it being explicit, just curious. > > Yea, it looks like you are right: https://doc.rust-lang.org/cargo/reference/profiles.html#dev > > I'm happy to remove it, or to leave it explicit. Now most rust tests is running in `--profile ci`, however this new `--profile ci-release` profile looks more reasonable to me 🤔 . Maybe their compilation time is longer then running time, so `--profile ci` makes CI faster? If someone can confirm this, we can add the explanation to https://github.com/apache/datafusion/blob/86cb815e03e5244a3a2c9757171c252a3a65181d/Cargo.toml#L230 However, for the extended SQLite test suite (which includes many test cases), the workload should be dominated by test execution time rather than compilation time, so this `ci-release` profile is likely necessary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
