timsaucer commented on code in PR #750: URL: https://github.com/apache/datafusion-python/pull/750#discussion_r1680924433
########## benchmarks/db-benchmark/join-datafusion.py: ########## @@ -74,7 +74,8 @@ def ans_shape(batches): ctx = df.SessionContext() print(ctx) -# TODO we should be applying projections to these table reads to crete relations of different sizes +# TODO we should be applying projections to these table reads to crete relations Review Comment: Changed ########## examples/substrait.py: ########## @@ -18,16 +18,15 @@ from datafusion import SessionContext from datafusion import substrait as ss +# TODO add user changing interface note to PR that datafusion.substrait.substrait is simplified to datafusion.substrait Review Comment: Done. comment removed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
