Jefffrey commented on code in PR #20851:
URL: https://github.com/apache/datafusion/pull/20851#discussion_r2922544403
##########
datafusion/expr/src/expr.rs:
##########
@@ -2858,7 +2858,29 @@ impl Display for SchemaDisplay<'_> {
}
}
Expr::BinaryExpr(BinaryExpr { left, op, right }) => {
- write!(f, "{} {op} {}", SchemaDisplay(left),
SchemaDisplay(right),)
+ fn write_child(
Review Comment:
Given we lift this logic from
https://github.com/apache/datafusion/blob/8d9b080882179b618a2057e042fc32865f6484b4/datafusion/expr/src/expr.rs#L621-L652
Would we need to fix it there too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
