Jefffrey commented on code in PR #20851:
URL: https://github.com/apache/datafusion/pull/20851#discussion_r2944201058
##########
datafusion/expr/src/expr.rs:
##########
@@ -2858,7 +2858,29 @@ impl Display for SchemaDisplay<'_> {
}
}
Expr::BinaryExpr(BinaryExpr { left, op, right }) => {
- write!(f, "{} {op} {}", SchemaDisplay(left),
SchemaDisplay(right),)
+ fn write_child(
Review Comment:
Now that I think about it, I'm not sure we need this adjustment 🤔
It would make things more verbose since `a AND b AND c` would now be
transformed into `a AND (b AND c)` right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
