buraksenn commented on code in PR #20904:
URL: https://github.com/apache/datafusion/pull/20904#discussion_r2925310392
##########
datafusion/physical-plan/src/joins/utils.rs:
##########
@@ -697,6 +710,78 @@ fn estimate_disjoint_inputs(
None
}
+/// Estimates the number of outer rows that have at least one matching
Review Comment:
This builds up on same assumption in the inner join in the same file
`estimate_inner_join_cardinality`. I saw similar thing in postgres
https://github.com/postgres/postgres/blob/02976b0a1718037f73fded250411b013e81fdafa/src/backend/utils/adt/selfuncs.c#L2718.
I may need to check Spark and Trino again. In the epic it said about them but
not sure about this.
If you have any reservations about I can close or maybe try to be more
conservative on this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
