asolimando commented on code in PR #20904:
URL: https://github.com/apache/datafusion/pull/20904#discussion_r2930071947
##########
datafusion/physical-plan/src/joins/utils.rs:
##########
@@ -697,6 +710,78 @@ fn estimate_disjoint_inputs(
None
}
+/// Estimates the number of outer rows that have at least one matching
Review Comment:
No reservations, but I think it's valuable to point to the original
implementation for multiple reasons: documentation, revisit the implementation
if the original source improves over it, and recognition for the original
author/project.
As I said, this looks reasonable and correct to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
