xitep commented on code in PR #2276:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2276#discussion_r2932334785
##########
src/parser/mod.rs:
##########
@@ -17518,11 +17521,15 @@ impl<'a> Parser<'a> {
}
/// Returns true if the immediate tokens look like the
- /// beginning of a subquery. `(SELECT ...`
- fn peek_subquery_start(&mut self) -> bool {
+ /// beginning of a subquery, e.g. `(SELECT ...`.
+ ///
+ /// If `full_query == true` attempt to detect a full query with its
+ /// optional, leading `WITH` clause, e.g. `(WITH ...)`
+ fn peek_subquery_start(&mut self, full_query: bool) -> bool {
Review Comment:
the two methods are simpler. :+1: but it ended up longer than you suggested
:/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
