alamb commented on code in PR #20924:
URL: https://github.com/apache/datafusion/pull/20924#discussion_r2933452506
##########
datafusion/physical-plan/src/repartition/mod.rs:
##########
@@ -1049,7 +1056,7 @@ impl ExecutionPlan for RepartitionExec {
Arc::clone(&reservation),
spill_stream,
1, // Each receiver handles one input partition
- BaselineMetrics::new(&metrics, partition),
+ BaselineMetrics::new(&intermediate_metrics,
partition),
Review Comment:
if we are just going to ignore the metrics, should we just remove them from
PerPartitionStream ?
It seems like using a local copy of ExecutionPlanMetrics means they metrics
in the PerPartitionStream are no longer accessable. So we can probably just
remove the metrics to make it clearer they aren't used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
