xanderbailey commented on code in PR #20924:
URL: https://github.com/apache/datafusion/pull/20924#discussion_r2933638415
##########
datafusion/physical-plan/src/repartition/mod.rs:
##########
@@ -1049,7 +1056,7 @@ impl ExecutionPlan for RepartitionExec {
Arc::clone(&reservation),
spill_stream,
1, // Each receiver handles one input partition
- BaselineMetrics::new(&metrics, partition),
+ BaselineMetrics::new(&intermediate_metrics,
partition),
Review Comment:
Yeah good question, we still use `PerPartitionStream` here
https://github.com/apache/datafusion/blob/01598d91b022d1f52ec92d16c432d98106ff0bbd/datafusion/physical-plan/src/repartition/mod.rs#L1085.
We can make the metrics optional which is maybe more explicit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
