Re: [PR] [Vibe] Fuse agg repartition [datafusion]

Fri, 13 Mar 2026 22:52:44 -0700 


adriangbot commented on PR #20934:
URL: https://github.com/apache/datafusion/pull/20934#issuecomment-4059662845

   ๐Ÿค– Benchmark completed (GKE) | 
[trigger](https://github.com/apache/datafusion/pull/20934#issuecomment-4059632543)
   
   <details><summary>Details</summary>
   <p>
   
   ```
   Comparing HEAD and fuse_agg_repartition
   --------------------
   Benchmark clickbench_extended.json
   --------------------
   
โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ณโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ณโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ณโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”“
   โ”ƒ Query    โ”ƒ                                    HEAD โ”ƒ                    
fuse_agg_repartition โ”ƒ    Change โ”ƒ
   
โ”กโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ•‡โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ•‡โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ•‡โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ฉ
   โ”‚ QQuery 0 โ”‚      820.94 / 831.03 ยฑ10.56 / 846.72 ms โ”‚       804.17 / 813.27 
ยฑ7.32 / 825.38 ms โ”‚ no change โ”‚
   โ”‚ QQuery 1 โ”‚       223.50 / 224.26 ยฑ0.51 / 225.08 ms โ”‚       223.73 / 225.41 
ยฑ1.25 / 227.43 ms โ”‚ no change โ”‚
   โ”‚ QQuery 2 โ”‚       523.37 / 525.98 ยฑ2.05 / 529.62 ms โ”‚       528.65 / 529.38 
ยฑ0.51 / 530.16 ms โ”‚ no change โ”‚
   โ”‚ QQuery 3 โ”‚       331.37 / 332.10 ยฑ0.55 / 332.85 ms โ”‚       333.27 / 335.03 
ยฑ1.41 / 337.53 ms โ”‚ no change โ”‚
   โ”‚ QQuery 4 โ”‚       674.50 / 684.32 ยฑ6.64 / 693.13 ms โ”‚      677.59 / 689.88 
ยฑ14.85 / 718.61 ms โ”‚ no change โ”‚
   โ”‚ QQuery 5 โ”‚ 9500.26 / 9870.92 ยฑ224.88 / 10120.21 ms โ”‚ 9725.86 / 9940.32 
ยฑ220.55 / 10222.38 ms โ”‚ no change โ”‚
   โ”‚ QQuery 6 โ”‚     986.48 / 996.01 ยฑ13.86 / 1023.32 ms โ”‚      987.17 / 992.45 
ยฑ4.69 / 1001.20 ms โ”‚ no change โ”‚
   โ”‚ QQuery 7 โ”‚       780.06 / 790.92 ยฑ9.18 / 804.33 ms โ”‚      780.63 / 800.62 
ยฑ12.10 / 813.19 ms โ”‚ no change โ”‚
   
โ””โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”ดโ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”ดโ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”ดโ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”˜
   โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ณโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”“
   โ”ƒ Benchmark Summary                   โ”ƒ            โ”ƒ
   โ”กโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ•‡โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ฉ
   โ”‚ Total Time (HEAD)                   โ”‚ 14255.54ms โ”‚
   โ”‚ Total Time (fuse_agg_repartition)   โ”‚ 14326.37ms โ”‚
   โ”‚ Average Time (HEAD)                 โ”‚  1781.94ms โ”‚
   โ”‚ Average Time (fuse_agg_repartition) โ”‚  1790.80ms โ”‚
   โ”‚ Queries Faster                      โ”‚          0 โ”‚
   โ”‚ Queries Slower                      โ”‚          0 โ”‚
   โ”‚ Queries with No Change              โ”‚          8 โ”‚
   โ”‚ Queries with Failure                โ”‚          0 โ”‚
   โ””โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”ดโ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”˜
   ```
   
   </p>
   </details>
   
   <details><summary>Resource Usage</summary>
   
   **clickbench_extended โ€” base (merge-base)**
   | Metric | Value |
   |--------|-------|
   | Wall time | 71.9s |
   | Peak memory | 32.3 GiB |
   | Avg memory | 28.4 GiB |
   | CPU user | 711.0s |
   | CPU sys | 22.2s |
   | Disk read | 0 B |
   | Disk write | 22.1 MiB |
   
   **clickbench_extended โ€” branch**
   | Metric | Value |
   |--------|-------|
   | Wall time | 72.2s |
   | Peak memory | 33.2 GiB |
   | Avg memory | 28.4 GiB |
   | CPU user | 720.1s |
   | CPU sys | 22.9s |
   | Disk read | 0 B |
   | Disk write | 272.0 KiB |
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to