Re: [PR] [Vibe] Fuse agg repartition [datafusion]

Fri, 13 Mar 2026 23:47:31 -0700 


adriangbot commented on PR #20934:
URL: https://github.com/apache/datafusion/pull/20934#issuecomment-4059783293

   ๐Ÿค– Benchmark completed (GKE) | 
[trigger](https://github.com/apache/datafusion/pull/20934#issuecomment-4059725134)
   
   <details><summary>Details</summary>
   <p>
   
   ```
   Comparing HEAD and fuse_agg_repartition
   --------------------
   Benchmark clickbench_extended.json
   --------------------
   
โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ณโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ณโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ณโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”“
   โ”ƒ Query    โ”ƒ                                      HEAD โ”ƒ                     
fuse_agg_repartition โ”ƒ    Change โ”ƒ
   
โ”กโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ•‡โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ•‡โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ•‡โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ฉ
   โ”‚ QQuery 0 โ”‚        876.02 / 894.16 ยฑ14.67 / 915.65 ms โ”‚       881.19 / 
895.71 ยฑ15.40 / 916.98 ms โ”‚ no change โ”‚
   โ”‚ QQuery 1 โ”‚         225.33 / 226.45 ยฑ0.81 / 227.37 ms โ”‚        224.65 / 
225.63 ยฑ0.83 / 226.58 ms โ”‚ no change โ”‚
   โ”‚ QQuery 2 โ”‚         527.31 / 528.82 ยฑ0.87 / 529.95 ms โ”‚        526.57 / 
530.25 ยฑ3.22 / 536.02 ms โ”‚ no change โ”‚
   โ”‚ QQuery 3 โ”‚         331.81 / 333.73 ยฑ1.63 / 336.53 ms โ”‚        335.37 / 
338.32 ยฑ3.26 / 344.66 ms โ”‚ no change โ”‚
   โ”‚ QQuery 4 โ”‚         694.14 / 706.66 ยฑ7.52 / 714.49 ms โ”‚       705.44 / 
721.78 ยฑ11.79 / 736.25 ms โ”‚ no change โ”‚
   โ”‚ QQuery 5 โ”‚ 10143.70 / 10297.80 ยฑ171.18 / 10614.77 ms โ”‚ 9599.41 / 10079.89 
ยฑ295.56 / 10454.95 ms โ”‚ no change โ”‚
   โ”‚ QQuery 6 โ”‚     1003.19 / 1023.75 ยฑ19.13 / 1059.80 ms โ”‚    1000.56 / 
1011.31 ยฑ13.26 / 1036.56 ms โ”‚ no change โ”‚
   โ”‚ QQuery 7 โ”‚         809.59 / 824.92 ยฑ9.58 / 836.78 ms โ”‚       814.76 / 
845.07 ยฑ16.12 / 859.60 ms โ”‚ no change โ”‚
   
โ””โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”ดโ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”ดโ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”ดโ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”˜
   โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ณโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”“
   โ”ƒ Benchmark Summary                   โ”ƒ            โ”ƒ
   โ”กโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ•‡โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ฉ
   โ”‚ Total Time (HEAD)                   โ”‚ 14836.29ms โ”‚
   โ”‚ Total Time (fuse_agg_repartition)   โ”‚ 14647.96ms โ”‚
   โ”‚ Average Time (HEAD)                 โ”‚  1854.54ms โ”‚
   โ”‚ Average Time (fuse_agg_repartition) โ”‚  1831.00ms โ”‚
   โ”‚ Queries Faster                      โ”‚          0 โ”‚
   โ”‚ Queries Slower                      โ”‚          0 โ”‚
   โ”‚ Queries with No Change              โ”‚          8 โ”‚
   โ”‚ Queries with Failure                โ”‚          0 โ”‚
   โ””โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”ดโ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”˜
   ```
   
   </p>
   </details>
   
   <details><summary>Resource Usage</summary>
   
   **clickbench_extended โ€” base (merge-base)**
   | Metric | Value |
   |--------|-------|
   | Wall time | 74.9s |
   | Peak memory | 33.3 GiB |
   | Avg memory | 28.0 GiB |
   | CPU user | 730.9s |
   | CPU sys | 24.2s |
   | Disk read | 0 B |
   | Disk write | 21.8 MiB |
   
   **clickbench_extended โ€” branch**
   | Metric | Value |
   |--------|-------|
   | Wall time | 73.9s |
   | Peak memory | 33.3 GiB |
   | Avg memory | 28.6 GiB |
   | CPU user | 729.9s |
   | CPU sys | 24.8s |
   | Disk read | 0 B |
   | Disk write | 84.0 KiB |
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to