findepi commented on PR #11508: URL: https://github.com/apache/datafusion/pull/11508#issuecomment-2234045984
> * The script traverses on changes for this particular PR? What I mean if there is already existing file in the repo exceeding the max size, the new PR check shouldn't complain on that correct. and yes, there is one 3.7 MB file in the repo > if the user accidentally added a large file in PR, the deleted it, would the PR pass through the check or user needs to recreate the PR? (I suppose it might be an issue with depth:0) good question - if the deletion is a separate commit, then no, the check will not pass - if the deletion is done by amending the commit, then yes, the check will pass Keeping failure in "deletion is a separate commit" case is right if the PR will be merged or rebase-merged, but unnecessary if the PR will be squash-merged. If the PRs are always squash-merged, we can improve the script to take this into account. But it can be view as overengineering, on the optimistic assumption that this will fail rarely anyway. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
