alamb commented on PR #11508: URL: https://github.com/apache/datafusion/pull/11508#issuecomment-2240031572
> @alamb there is a small side effect described above which may give a false positive and basically may require PR recreate, which doesn't seem a big problem for me but for large complex PRs the user might be distressed to recreate it after hard rebase. But this is pretty rare case I agree with @findepi that there is a fairly easy workaround that doesn't need to recreate the PR (it would require rebasing it). I think we should try this and we can always adjust as neessary if we find something isn't ideal Thank you very much @findepi and @comphead -- I think this is a nice improvement -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
