Re: [PR] bench: Batched accumulator storage for hash aggregation [datafusion]

Mon, 16 Mar 2026 10:02:23 -0700 


adriangbot commented on PR #20964:
URL: https://github.com/apache/datafusion/pull/20964#issuecomment-4069194458

   ๐Ÿค– Benchmark completed (GKE) | 
[trigger](https://github.com/apache/datafusion/pull/20964#issuecomment-4069055822)
   
   <details><summary>Details</summary>
   <p>
   
   ```
   Comparing HEAD and batched-accumulator-storage
   --------------------
   Benchmark clickbench_extended.json
   --------------------
   
โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ณโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ณโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ณโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”“
   โ”ƒ Query    โ”ƒ                                     HEAD โ”ƒ              
batched-accumulator-storage โ”ƒ        Change โ”ƒ
   
โ”กโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ•‡โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ•‡โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ•‡โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ฉ
   โ”‚ QQuery 0 โ”‚      981.84 / 998.87 ยฑ12.71 / 1017.97 ms โ”‚       817.79 / 
927.62 ยฑ82.24 / 998.61 ms โ”‚ +1.08x faster โ”‚
   โ”‚ QQuery 1 โ”‚        227.76 / 229.51 ยฑ1.79 / 232.18 ms โ”‚        223.91 / 
225.52 ยฑ1.15 / 227.47 ms โ”‚     no change โ”‚
   โ”‚ QQuery 2 โ”‚        530.41 / 536.14 ยฑ3.78 / 539.98 ms โ”‚        527.88 / 
531.60 ยฑ3.83 / 538.43 ms โ”‚     no change โ”‚
   โ”‚ QQuery 3 โ”‚        330.66 / 334.49 ยฑ3.02 / 339.01 ms โ”‚        340.56 / 
342.45 ยฑ1.08 / 343.62 ms โ”‚     no change โ”‚
   โ”‚ QQuery 4 โ”‚       673.42 / 711.29 ยฑ30.78 / 749.66 ms โ”‚        696.84 / 
706.37 ยฑ6.21 / 714.41 ms โ”‚     no change โ”‚
   โ”‚ QQuery 5 โ”‚ 9797.86 / 10168.58 ยฑ211.62 / 10425.24 ms โ”‚ 9829.24 / 10227.51 
ยฑ257.98 / 10484.92 ms โ”‚     no change โ”‚
   โ”‚ QQuery 6 โ”‚     995.49 / 1025.85 ยฑ24.03 / 1064.86 ms โ”‚     987.39 / 1000.20 
ยฑ19.17 / 1038.36 ms โ”‚     no change โ”‚
   โ”‚ QQuery 7 โ”‚       821.59 / 866.99 ยฑ22.84 / 883.06 ms โ”‚       908.95 / 
939.46 ยฑ17.10 / 958.59 ms โ”‚  1.08x slower โ”‚
   
โ””โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”ดโ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”ดโ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”ดโ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”˜
   โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ณโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”“
   โ”ƒ Benchmark Summary                          โ”ƒ            โ”ƒ
   โ”กโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ•‡โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ฉ
   โ”‚ Total Time (HEAD)                          โ”‚ 14871.73ms โ”‚
   โ”‚ Total Time (batched-accumulator-storage)   โ”‚ 14900.74ms โ”‚
   โ”‚ Average Time (HEAD)                        โ”‚  1858.97ms โ”‚
   โ”‚ Average Time (batched-accumulator-storage) โ”‚  1862.59ms โ”‚
   โ”‚ Queries Faster                             โ”‚          1 โ”‚
   โ”‚ Queries Slower                             โ”‚          1 โ”‚
   โ”‚ Queries with No Change                     โ”‚          6 โ”‚
   โ”‚ Queries with Failure                       โ”‚          0 โ”‚
   โ””โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”ดโ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”˜
   ```
   
   </p>
   </details>
   
   <details><summary>Resource Usage</summary>
   
   **clickbench_extended โ€” base (merge-base)**
   | Metric | Value |
   |--------|-------|
   | Wall time | 75.0s |
   | Peak memory | 32.4 GiB |
   | Avg memory | 27.6 GiB |
   | CPU user | 737.1s |
   | CPU sys | 24.9s |
   | Disk read | 0 B |
   | Disk write | 22.5 MiB |
   
   **clickbench_extended โ€” branch**
   | Metric | Value |
   |--------|-------|
   | Wall time | 75.2s |
   | Peak memory | 32.0 GiB |
   | Avg memory | 27.6 GiB |
   | CPU user | 740.9s |
   | CPU sys | 24.0s |
   | Disk read | 0 B |
   | Disk write | 692.0 KiB |
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to