alamb commented on code in PR #20958:
URL: https://github.com/apache/datafusion/pull/20958#discussion_r2942958440
##########
datafusion/sqllogictest/test_files/aggregate.slt:
##########
@@ -1776,7 +1776,7 @@ SELECT approx_distinct(null)
query II
SELECT approx_distinct(c9) AS a, approx_distinct(c9) AS b FROM
aggregate_test_100
----
-100 100
+99 99
Review Comment:
it is also consistent with the results from the query above which shows a
slight difference
It is weird that approx_distinct in this query is 99 but it is 100 in the
query right above it 🤔
##########
datafusion/proto/proto/datafusion.proto:
##########
@@ -1041,9 +1041,9 @@ message PhysicalExtensionExprNode {
message PhysicalHashExprNode {
repeated PhysicalExprNode on_columns = 1;
uint64 seed0 = 2;
- uint64 seed1 = 3;
- uint64 seed2 = 4;
- uint64 seed3 = 5;
+ // uint64 seed1 = 3;
Review Comment:
do we need this still? Shall we just remove them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
