Dandandan commented on code in PR #20958:
URL: https://github.com/apache/datafusion/pull/20958#discussion_r2942405906
##########
datafusion/physical-plan/src/aggregates/mod.rs:
##########
@@ -87,8 +87,16 @@ pub fn topk_types_supported(key_type: &DataType, value_type:
&DataType) -> bool
}
/// Hard-coded seed for aggregations to ensure hash values differ from
`RepartitionExec`, avoiding collisions.
-const AGGREGATION_HASH_SEED: ahash::RandomState =
- ahash::RandomState::with_seeds('A' as u64, 'G' as u64, 'G' as u64, 'R' as
u64);
+const AGGREGATION_HASH_SEED: datafusion_common::hash_utils::RandomState =
+ datafusion_common::hash_utils::RandomState::with_seed(
+ ('A' as u64)
+ .wrapping_mul(6364136223846793005)
Review Comment:
I made it just a random one now.
IMO we should also review the use of those fixed seeds in the code - I think
some of them can be safely replaced by `RandomState::default()` without any
issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
