wForget commented on code in PR #3708:
URL: https://github.com/apache/datafusion-comet/pull/3708#discussion_r2945154846
##########
spark/src/main/scala/org/apache/spark/Plugins.scala:
##########
@@ -101,6 +107,10 @@ class CometDriverPlugin extends DriverPlugin with Logging
with ShimCometDriverPl
}
object CometDriverPlugin extends Logging {
+ def registerQueryExecutionListener(conf: SparkConf): Unit = {
Review Comment:
1. move `sc.env.metricsSystem.registerSource(CometSource)` into this method,
and add a configuration to make this behavior configurable
2. Check if `spark.sql.queryExecutionListeners` is configured and merge it.
You can refer to the implementation of `registerCometSessionExtension` method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
