myandpr commented on code in PR #21032:
URL: https://github.com/apache/datafusion/pull/21032#discussion_r2958724468
##########
datafusion/expr/src/type_coercion/functions.rs:
##########
@@ -325,24 +325,20 @@ fn get_valid_types_with_udf<F: UDFCoercionExt>(
},
TypeSignature::OneOf(signatures) => {
let mut res = vec![];
- let mut errors = vec![];
for sig in signatures {
- match get_valid_types_with_udf(sig, current_types, func) {
- Ok(valid_types) => {
- res.extend(valid_types);
- }
- Err(e) => {
Review Comment:
Thanks @martin-g , updated this to defer non-`Plan` errors until all
`OneOf` branches have been checked, so valid matches still succeed and
non-`Plan` errors are only surfaced when every branch fails.
Would you mind taking another look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
