iffyio commented on code in PR #2223:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2223#discussion_r2964934022
##########
src/ast/helpers/stmt_data_loading.rs:
##########
@@ -78,8 +80,9 @@ pub struct StageLoadSelectItem {
pub alias: Option<Ident>,
/// Column number within the staged file (1-based).
pub file_col_num: i32,
- /// Optional element identifier following the column reference.
- pub element: Option<Ident>,
+ /// Optional semi-structured element path following the column reference
+ /// (e.g. `$1:UsageMetrics:hh` produces `["UsageMetrics", "hh"]`).
+ pub element: Option<Vec<Ident>>,
Review Comment:
I wonder, can we change this to `element: Vec<Ident>` to drop the option?
feels like in this case it would be simpler if the Option no longer covers the
previous intent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
