coderfender commented on code in PR #21030:
URL: https://github.com/apache/datafusion/pull/21030#discussion_r2965761059
##########
datafusion/ffi/src/udf/mod.rs:
##########
@@ -45,7 +45,7 @@ use crate::expr::columnar_value::FFI_ColumnarValue;
use crate::util::{
FFIResult, rvec_wrapped_to_vec_datatype, vec_datatype_to_rvec_wrapped,
};
-use crate::volatility::FFI_Volatility;
+use crate::volatility::FfiVolatility;
Review Comment:
Thank you for the comment @timsaucer . I had to rename these structs to fix
clippy errors . Do you think we should stick with clippy recommended naming
convention or we could revert to use arrow's convention and ignore clippy
warnings ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
