coderfender commented on code in PR #21030:
URL: https://github.com/apache/datafusion/pull/21030#discussion_r2965878961
##########
datafusion/ffi/src/udf/mod.rs:
##########
@@ -45,7 +45,7 @@ use crate::expr::columnar_value::FFI_ColumnarValue;
use crate::util::{
FFIResult, rvec_wrapped_to_vec_datatype, vec_datatype_to_rvec_wrapped,
};
-use crate::volatility::FFI_Volatility;
+use crate::volatility::FfiVolatility;
Review Comment:
I think now is a good time to make it clippy complaint given that we are
making a major change . However, if the goal is to keep it consistent with
Arrow's notation I can go ahead and revert the naming convention
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
