andygrove commented on code in PR #3656:
URL: https://github.com/apache/datafusion-comet/pull/3656#discussion_r2965940777
##########
native/spark-expr/src/conversion_funcs/string.rs:
##########
@@ -1095,31 +1108,31 @@ fn timestamp_parser<T: TimeZone>(
// Define regex patterns and corresponding parsing functions
let patterns = &[
(
- Regex::new(r"^\d{4,5}$").unwrap(),
+ Regex::new(r"^\d{4,7}$").unwrap(),
Review Comment:
I already commented on this on the other PR, but are these regexes compiled
on each invocation or are these static? I wasn't sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
