andygrove commented on code in PR #3656:
URL: https://github.com/apache/datafusion-comet/pull/3656#discussion_r2965933476
##########
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##########
@@ -951,19 +954,47 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
}
}
- test("cast StringType to TimestampType disabled by default") {
- withSQLConf((SQLConf.SESSION_LOCAL_TIMEZONE.key, "UTC")) {
- val values = Seq("2020-01-01T12:34:56.123456", "T2").toDF("a")
- castFallbackTest(
- values.toDF("a"),
- DataTypes.TimestampType,
- "Not all valid formats are supported")
+ test("cast StringType to TimestampType - UTC") {
+ withSQLConf(SQLConf.SESSION_LOCAL_TIMEZONE.key -> "UTC") {
Review Comment:
cast from string to timestamp is marked as incompatible. Does it need to be
enabled here by enabling the relevant config?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
