getChan commented on code in PR #17861: URL: https://github.com/apache/datafusion/pull/17861#discussion_r2971763743
########## datafusion/sqllogictest/test_files/avro.slt: ########## @@ -99,15 +99,15 @@ CREATE EXTERNAL TABLE alltypes_plain_zstandard ( float_col FLOAT NOT NULL, double_col DOUBLE NOT NULL, date_string_col BYTEA NOT NULL, - string_col VARCHAR NOT NULL, + string_col BYTEA NOT NULL, timestamp_col TIMESTAMP NOT NULL, ) STORED AS AVRO LOCATION '../../testing/data/avro/alltypes_plain.zstandard.avro'; statement ok CREATE EXTERNAL TABLE single_nan ( - mycol FLOAT + mycol DOUBLE Review Comment: Agreed. I did not treat this as an intentional contract change. I restored the original `.slt` expectations so the external table schema remains part of the user-visible decode contract (for example `string_col VARCHAR` without requiring query-time casts), and handled the fix in the reader path instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
