parthchandra commented on code in PR #678:
URL: https://github.com/apache/datafusion-comet/pull/678#discussion_r1681847829
##########
dev/diffs/4.0.0-preview1.diff:
##########
@@ -938,16 +938,42 @@ index 68f14f13bbd..4b8e967102f 100644
}
assert(exchanges.size === 1)
}
-@@ -2668,7 +2675,8 @@ class SubquerySuite extends QueryTest
- }
- }
-
-- test("SPARK-43402: FileSourceScanExec supports push down data filter with
scalar subquery") {
-+ test("SPARK-43402: FileSourceScanExec supports push down data filter with
scalar subquery",
-+ IgnoreComet("TODO:
https://github.com/apache/datafusion-comet/issues/551";)) {
+@@ -2672,18 +2679,26 @@ class SubquerySuite extends QueryTest
def checkFileSourceScan(query: String, answer: Seq[Row]): Unit = {
val df = sql(query)
checkAnswer(df, answer)
+- val fileSourceScanExec = collect(df.queryExecution.executedPlan) {
+- case f: FileSourceScanExec => f
+- }
+ sparkContext.listenerBus.waitUntilEmpty()
Review Comment:
The change was not intentional. Corrected. The tests did not fail, but I'm
sure that flushing the listener bus was there for a reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
