theirix commented on code in PR #20787:
URL: https://github.com/apache/datafusion/pull/20787#discussion_r2978028198
##########
datafusion/functions/src/strings.rs:
##########
@@ -165,6 +187,12 @@ impl StringViewArrayBuilder {
self.block.push_str(array.value(i));
}
}
+ ColumnarValueRef::NullableBinaryArray(array) => {
Review Comment:
Good catch! I added tests and introduced the same approach to
`StringViewArrayBuilder`, using unsafe only when operations don't taint the
buffer. Also, it should be more performant since we do UTF-8 validation once.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
