coderfender commented on code in PR #21030:
URL: https://github.com/apache/datafusion/pull/21030#discussion_r2986072620
##########
datafusion-examples/examples/ffi/ffi_example_table_provider/src/lib.rs:
##########
@@ -56,11 +55,10 @@ extern "C" fn construct_simple_table_provider(
FFI_TableProvider::new_with_ffi_codec(Arc::new(table_provider), true,
None, codec)
}
-#[export_root_module]
+#[unsafe(no_mangle)]
Review Comment:
Error when I used `stabby::export` but please let me know if you think I am
missing something here :
```
pub extern "C" fn ffi_example_get_module() -> TableProviderModule {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the
trait `IStable` is not implemented for `TableProviderModule` ```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
