Copilot commented on code in PR #21171:
URL: https://github.com/apache/datafusion/pull/21171#discussion_r2993520871
##########
AGENTS.md:
##########
@@ -15,6 +15,24 @@ Before committing any changes, you MUST follow the
instructions in
and ensure the required checks listed there pass. Do not commit code that
fails any of those checks.
+At a minimum, you MUST run and fix any errors from these commands before
+committing:
+
+```bash
+# Format code
+cargo fmt --all
+
+# Lint (must pass with no warnings)
Review Comment:
The recommended clippy invocation here doesn’t match the repository’s CI
lint configuration: `ci/scripts/rust_clippy.sh` runs clippy with `--workspace`
and a specific feature set ("avro,integration-tests,extended_tests"), not
`--all-features`. Since this section uses MUST language, please either align
the documented command with the CI clippy flags (or point readers to
`./ci/scripts/rust_clippy.sh` / `./dev/rust_lint.sh` for the exact
CI-equivalent command) or explicitly call out that `--all-features` is
intentionally stricter/different than CI.
```suggestion
# Lint (must pass with no warnings)
# Note: this runs clippy with --all-features, which is intentionally
stricter than CI.
# To match CI exactly, use ./dev/rust_lint.sh as shown below.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
