AdamGS commented on code in PR #21128:
URL: https://github.com/apache/datafusion/pull/21128#discussion_r3002264056
##########
datafusion/optimizer/src/push_down_limit.rs:
##########
@@ -47,12 +47,12 @@ impl OptimizerRule for PushDownLimit {
true
}
+ #[expect(clippy::only_used_in_recursion)]
fn rewrite(
&self,
plan: LogicalPlan,
config: &dyn OptimizerConfig,
) -> Result<Transformed<LogicalPlan>> {
- let _ = config.options();
Review Comment:
to answer your question above, I think the lint has to stay here because
this seems worse, and as far as I can tell in this rule the config is just
passed along recursively
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
