AdamGS commented on code in PR #21128:
URL: https://github.com/apache/datafusion/pull/21128#discussion_r3002423682
##########
datafusion/optimizer/src/push_down_filter.rs:
##########
@@ -320,10 +320,8 @@ fn can_evaluate_as_join_condition(predicate: &Expr) ->
Result<bool> {
/// * do nothing.
fn extract_or_clauses_for_join<'a>(
filters: &'a [Expr],
- schema: &'a DFSchema,
+ schema_cols: &'a HashSet<Column>,
Review Comment:
I pushed a change, it widen the scope by a bit but basically just introduces
a type that holds two references and passes it around, everything is contained
within the module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
