LiaCastaneda commented on code in PR #18921: URL: https://github.com/apache/datafusion/pull/18921#discussion_r3002224991
########## datafusion/functions-nested/src/array_transform.rs: ########## Review Comment: 🤔 This is a good point I was not aware of. It's tricky because in `array_transform` this could be a problem or not depending on which expression it gets (if it's a multiplication it's not an issue but if it's a division it is), so I imagine the best option here is to be conservative and always clean up. Although, we do have cheap ways to know if arrow Arrays have nulls (`array.null_count()` etc), so we could skip the cleanup entirely when there are no nulls. I guess this cleanup would be the same for all lambda functions, so it probably makes sense to handle it transparently in datafusion before calling the user's invoke? That way implementors never have to think about it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
