LiaCastaneda commented on code in PR #18921: URL: https://github.com/apache/datafusion/pull/18921#discussion_r3004938118
########## datafusion/functions-nested/src/array_transform.rs: ########## Review Comment: fwiw I looked into how Trino handles this, and they simply don't apply the function in a vectorized way -- they have [one for loop](https://github.com/trinodb/trino/blob/2aae427ebf8e18477cec163065df4ae0f4575307/core/trino-main/src/main/java/io/trino/operator/scalar/ArrayTransformFunction.java#L199) that checks for nulls and applies the lambda per element. IMO it's great to be able to execute this in a vectorized way in DataFusion even if the price to pay is the null cleanup (which is only necessary on arrays with nulls). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
