parthchandra commented on code in PR #3708: URL: https://github.com/apache/datafusion-comet/pull/3708#discussion_r3002354059
########## spark/src/main/scala/org/apache/comet/CometMetricsListener.scala: ########## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.comet + +import org.apache.spark.CometSource +import org.apache.spark.sql.execution.QueryExecution +import org.apache.spark.sql.util.QueryExecutionListener + +class CometMetricsListener extends QueryExecutionListener { + + override def onSuccess(funcName: String, qe: QueryExecution, durationNs: Long): Unit = { + val stats = CometCoverageStats.forPlan(qe.executedPlan) + CometSource.recordStats(stats) + } + + override def onFailure(funcName: String, qe: QueryExecution, exception: Exception): Unit = {} Review Comment: Technically, the query is still planned even if it fails. You could increment queries_planned here if you want to. ########## common/src/main/scala/org/apache/comet/CometConf.scala: ########## @@ -805,6 +805,19 @@ object CometConf extends ShimCometConf { .longConf .createWithDefault(3000L) + val COMET_METRICS_ENABLED: ConfigEntry[Boolean] = + conf("spark.comet.metrics.enabled") + .category(CATEGORY_EXEC) + .doc( + "Whether to enable Comet metrics reporting through Spark's external monitoring system. " + + "When enabled, Comet exposes metrics such as native operators, Spark operators, " + + "queries planned, transitions, and acceleration ratio. These metrics can be " + + "visualized through tools like Grafana when a metrics sink (e.g., Prometheus) is " + + "configured. Disabled by default because Spark plan traversal adds overhead and " + + "metrics require a sink to be useful.") Review Comment: Maybe add that this config only takes effect if set before the SparkSession is created. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
